New Sample Autoscaling + Monitoring #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Aug 18, 2025
shijiesheng
reviewed
Aug 18, 2025
cmd/samples/advanced/autoscaling-monitoring/prometheus_server.go
Outdated
Show resolved
Hide resolved
added 16 commits
August 19, 2025 15:43
shijiesheng
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
Create a sample demonstrating the new poller auto-scaling feature in the Go client worker.
What I did:
Created a new sample called "autoscaling-monitoring" under cmd/samples/advanced. The sample is independent of config/development.yaml and can be copied to another project and run independently. It demonstrates how to enable and use the Auto Scaler and add a metrics endpoint for Prometheus. The README includes comprehensive instructions on how to run everything and provides a link to observe the new dashboards for viewing auto-scaling metrics.
Caveats:
The debate continues between using cmd/samples and new_samples. This sample doesn't really fit in either category as it's not a workflow sample—it's all about the worker configuration and adding a Prometheus endpoint. To avoid polluting either of the existing directories, I created a novel sample type: cmd/samples/advanced. Let me know what you all think about this approach.
PS:
To view the dashboards you will need this: cadence-workflow/cadence#7177